Fix for value labels in email where value is 0. #5387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5387 +/- ##
==========================================
- Coverage 82.43% 82.42% -0.01%
==========================================
Files 417 417
Lines 33107 33107
Branches 5332 5332
==========================================
- Hits 27292 27290 -2
- Misses 4235 4237 +2
Partials 1580 1580 ☔ View full report in Codecov by Sentry. |
MorayMySoc
approved these changes
Feb 26, 2025
The IF check in the template was skipping fields with a value of "0".
dracos
force-pushed
the
email-extra-field-labels-fix
branch
from
ff552ff to
ceb0b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IF check in the template was skipping fields with a value of "0". [skip changelog]